reduce cloudwatch throttling delay

aws-cloudformation · Oct 24, 2020 · 5075e27 · 5075e27
1 parent 73afc2d
commit 5075e27
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 31 deletions.
diff --git a/src/log-delivery.ts b/src/log-delivery.ts
@@ -126,7 +126,7 @@ export class CloudWatchLogPublisher extends LogPublisher {
         }
         try {
             // Delay to avoid throttling
-            await delay(0.25);
+            await delay(0.1);
             const record: InputLogEvent = {
                 message,
                 timestamp: Math.round(eventTime.getTime()),
@@ -222,7 +222,6 @@ export class CloudWatchLogPublisher extends LogPublisher {
  *   * logs:CreateLogGroup
  *   * logs:CreateLogStream
  *   * logs:DescribeLogGroups
- *   * logs:DescribeLogStreams
  */
 export class CloudWatchLogHelper {
     private client: CloudWatchLogs;
@@ -262,7 +261,7 @@ export class CloudWatchLogHelper {
             );
             await this.emitMetricsForLoggingFailure(err);
         }
-        return null;
+        return Promise.resolve(null);
     }
 
     private async doesLogGroupExist(): Promise<boolean> {

diff --git a/src/metrics.ts b/src/metrics.ts
@@ -200,25 +200,19 @@ export class MetricsPublisherProxy {
         timestamp: Date,
         action: Action,
         error: Error
-    ): Promise<any> {
-        const promises: Array<Promise<void>> = this.publishers.map(
-            (publisher: MetricsPublisher) => {
-                return publisher.publishExceptionMetric(timestamp, action, error);
-            }
-        );
-        return await Promise.all(promises);
+    ): Promise<void> {
+        for (const publisher of this.publishers) {
+            await publisher.publishExceptionMetric(timestamp, action, error);
+        }
     }
 
     /**
      * Publishes a metric related to invocations to the list of publishers
      */
-    async publishInvocationMetric(timestamp: Date, action: Action): Promise<any> {
-        const promises: Array<Promise<void>> = this.publishers.map(
-            (publisher: MetricsPublisher) => {
-                return publisher.publishInvocationMetric(timestamp, action);
-            }
-        );
-        return await Promise.all(promises);
+    async publishInvocationMetric(timestamp: Date, action: Action): Promise<void> {
+        for (const publisher of this.publishers) {
+            await publisher.publishInvocationMetric(timestamp, action);
+        }
     }
 
     /**
@@ -228,13 +222,10 @@ export class MetricsPublisherProxy {
         timestamp: Date,
         action: Action,
         milliseconds: number
-    ): Promise<any> {
-        const promises: Array<Promise<void>> = this.publishers.map(
-            (publisher: MetricsPublisher) => {
-                return publisher.publishDurationMetric(timestamp, action, milliseconds);
-            }
-        );
-        return await Promise.all(promises);
+    ): Promise<void> {
+        for (const publisher of this.publishers) {
+            await publisher.publishDurationMetric(timestamp, action, milliseconds);
+        }
     }
 
     /**
@@ -243,12 +234,9 @@ export class MetricsPublisherProxy {
     async publishLogDeliveryExceptionMetric(
         timestamp: Date,
         error: Error
-    ): Promise<any> {
-        const promises: Array<Promise<void>> = this.publishers.map(
-            (publisher: MetricsPublisher) => {
-                return publisher.publishLogDeliveryExceptionMetric(timestamp, error);
-            }
-        );
-        return await Promise.all(promises);
+    ): Promise<void> {
+        for (const publisher of this.publishers) {
+            await publisher.publishLogDeliveryExceptionMetric(timestamp, error);
+        }
     }
 }