Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: various issues left over from iOS Combine feature doc push #2246

Merged
merged 4 commits into from
Aug 19, 2020

Conversation

palpatim
Copy link
Member

Issue #, if available:

Do not merge this until aws-amplify/amplify-swift#719 is released to prod

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@palpatim palpatim marked this pull request as ready for review August 19, 2020 16:09
@palpatim
Copy link
Member Author

aws-amplify/amplify-swift#719 released on 1.1.1. Ready for review

Copy link
Contributor

@royjit royjit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@palpatim palpatim merged commit 73179aa into master Aug 19, 2020
@palpatim palpatim deleted the palpatim/combine-fixes branch August 19, 2020 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants