-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve Confirm Password Error Validation #858
Changes from 8 commits
6746ff4
6c4da2f
e655083
dc62d66
24331fb
8f8f118
25c7dd6
032b48b
15c8b02
86533e8
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
--- | ||
'@aws-amplify/ui-angular': patch | ||
'@aws-amplify/ui-react': patch | ||
'@aws-amplify/ui': patch | ||
'@aws-amplify/ui-vue': patch | ||
--- | ||
|
||
Updated the password validation logic, so errors are only display on blur, or when six or more characters is typed for both the confirm password and password fields. |
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -7,7 +7,10 @@ Given('I click {string}', (text: string) => { | |
}); | ||
|
||
When('I confirm my password', () => { | ||
cy.findInputField('Confirm Password').type(Cypress.env('VALID_PASSWORD')); | ||
cy.findInputField('Confirm Password') | ||
.type(Cypress.env('VALID_PASSWORD')) | ||
.blur() | ||
.wait(100); | ||
}); | ||
Comment on lines
+10
to
14
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. There is something odd timing wise, that I cannot duplicate in real life only in cypress. Where if you send the blur at the exact same time as you click the acknowledgement button it causes the validation not to fire and the button won't light up. That's why I added a wait in here. Not sure if there is a better way of handling the blur... There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Weird, we can keep an eye on it. Fortunately (and unfortunately) this isn't human-reproducible, so I'm good with the changes! There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
|
||
Then('I see {string} as an input field', (name: string) => { | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Angular linter complained here if I called this
blur
oronblur
. So I changed the name tosetBlur