Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): reduce angular e2e flakiness #6373

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

jjarvisp
Copy link
Member

@jjarvisp jjarvisp commented Feb 20, 2025

Description of changes

The purpose of this change is to reduce flakiness associated with E2E tests by initializing intercept listeners earlier in test execution step (prior to firing intercept target).

Sample run:
https://github.com/aws-amplify/amplify-ui/actions/runs/13442552437?pr=6373

Issue #, if available

Description of how you validated changes

  • e2e tests

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@jjarvisp jjarvisp changed the title POC: running e2e tests against PR chore(ci): reduce angular e2e flakiness Feb 20, 2025
@jjarvisp jjarvisp marked this pull request as ready for review February 20, 2025 19:24
@jjarvisp jjarvisp requested a review from a team as a code owner February 20, 2025 19:24
@jjarvisp jjarvisp merged commit 6a186d5 into main Feb 20, 2025
34 checks passed
@jjarvisp jjarvisp deleted the james/fix/angular-e2e branch February 20, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants