Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react-storage): fix createStorageBrowser type issue #6217

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

ashwinkumar6
Copy link
Member

@ashwinkumar6 ashwinkumar6 commented Nov 29, 2024

Description of changes

expose additional storage browser types

Description of how you validated changes

linked and tested react-storage package locally

Checklist

  • Have read the Pull Request Guidelines
  • PR description included
  • yarn test passes and tests are updated/added
  • PR title and commit messages follow conventional commit syntax
  • If this change should result in a version bump, changeset added (This can be done after creating the PR.) This does not apply to changes made to docs, e2e, examples, or other private packages.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@ashwinkumar6 ashwinkumar6 requested a review from a team as a code owner November 29, 2024 19:25
Copy link

changeset-bot bot commented Nov 29, 2024

⚠️ No Changeset found

Latest commit: d80ade5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

calebpollman
calebpollman previously approved these changes Nov 29, 2024
@ashwinkumar6 ashwinkumar6 force-pushed the stoBro-additional-types branch from 89dd87a to d80ade5 Compare November 29, 2024 20:33
@ashwinkumar6 ashwinkumar6 changed the title fix(react-storage): expore additional storage browser types fix(react-storage): fix createStorageBrowser type issue Nov 29, 2024
@ashwinkumar6 ashwinkumar6 merged commit c59b2e2 into main Nov 29, 2024
34 checks passed
@ashwinkumar6 ashwinkumar6 deleted the stoBro-additional-types branch November 29, 2024 21:09
ashwinkumar6 added a commit that referenced this pull request Nov 29, 2024
calebpollman added a commit that referenced this pull request Nov 29, 2024
ashwinkumar6 added a commit that referenced this pull request Nov 29, 2024
* Revert "fix(react-storage): fix createStorageBrowser type issue (#6217)"

This reverts commit c59b2e2.

* fix(react-storage): expose additional storage browser types

* Update packages/react-storage/src/components/StorageBrowser/actions/configs/types.ts

Co-authored-by: Caleb Pollman <cpollman@amazon.com>

* Update packages/react-storage/src/components/StorageBrowser/types.ts

Co-authored-by: Caleb Pollman <cpollman@amazon.com>

* Update packages/react-storage/src/components/StorageBrowser/types.ts

Co-authored-by: Caleb Pollman <cpollman@amazon.com>

* Create nine-berries-smile.md

---------

Co-authored-by: Caleb Pollman <cpollman@amazon.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants