chore: fix issue where drag and drop throws illegal invocation #6145
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d041302 The changes in this PR will be included in the next version bump. This PR includes changesets to release 11 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Approving, assuming that we tested that folder structure is maintained upon parsing and upload when drag/dropping a directory. |
jordanvn
approved these changes
Nov 18, 2024
ashika112
approved these changes
Nov 18, 2024
Merged
dindjarinjs
added a commit
that referenced
this pull request
Nov 19, 2024
* chore: fix issue where drag and drop throws illegal invocation * Create dry-points-fold.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
Fixes an issue where dropping a file in the dropzone results in the following error message:
This error is due to the webkitGetAsEntry method being destructured off the DataTransferItem, resulting it not being able to act on the item. Fix is to stop destructuring properties off of the
DataTransferItem.Issue #, if available
Description of how you validated changes
Checklist
yarn testpasses and tests are updated/addeddocs,e2e,examples, or other private packages.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.