Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixing option background color in darkmode for Firefox #1110

Merged
merged 2 commits into from
Jan 10, 2022

Conversation

zchenwei
Copy link
Contributor

@zchenwei zchenwei commented Jan 7, 2022

Issue #, if available:
#1104

Description of changes:

Firefox default background color on option is not friendly in dark mode. This can be resolved by adding a more readable custom background color, targeting Firefox only.

Testing on Firefox 95.0

Screen Shot 2022-01-06 at 4 29 41 PM

Screen Shot 2022-01-06 at 4 30 12 PM

Screen Shot 2022-01-06 at 4 30 55 PM

Screen Shot 2022-01-06 at 4 31 14 PM

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Jan 7, 2022

🦋 Changeset detected

Latest commit: 500bae8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@aws-amplify/ui Patch
@aws-amplify/ui-react Patch
@aws-amplify/ui-vue Patch
@aws-amplify/ui-angular Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1110.d3inl0muob87le.amplifyapp.com

@zchenwei zchenwei temporarily deployed to ci January 7, 2022 00:57 Inactive
@zchenwei zchenwei temporarily deployed to ci January 7, 2022 00:57 Inactive
@zchenwei zchenwei temporarily deployed to ci January 7, 2022 00:57 Inactive
@zchenwei zchenwei temporarily deployed to ci January 7, 2022 00:57 Inactive
Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zchenwei zchenwei merged commit 87af741 into main Jan 10, 2022
@zchenwei zchenwei deleted the fix-countrycodeselect-darkmode branch January 10, 2022 17:44
@github-actions github-actions bot mentioned this pull request Jan 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants