Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tsup config typo fix #1035

Merged
merged 2 commits into from
Dec 21, 2021
Merged

Tsup config typo fix #1035

merged 2 commits into from
Dec 21, 2021

Conversation

ErikCH
Copy link
Contributor

@ErikCH ErikCH commented Dec 21, 2021

Issue #, if available:
#1027

Description of changes:
Remove extra ` character

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@changeset-bot
Copy link

changeset-bot bot commented Dec 21, 2021

🦋 Changeset detected

Latest commit: 06ddac8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@aws-amplify/ui-react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1035.d3inl0muob87le.amplifyapp.com

Copy link
Contributor

@reesscot reesscot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ErikCH ErikCH temporarily deployed to ci December 21, 2021 19:10 Inactive
@ErikCH ErikCH temporarily deployed to ci December 21, 2021 19:10 Inactive
@ErikCH ErikCH temporarily deployed to ci December 21, 2021 19:10 Inactive
@ErikCH ErikCH temporarily deployed to ci December 21, 2021 19:10 Inactive
Copy link
Contributor

@zchenwei zchenwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch BTW

@aws-amplify-us-east-2
Copy link

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-1035.d3inl0muob87le.amplifyapp.com

@ErikCH ErikCH temporarily deployed to ci December 21, 2021 20:05 Inactive
@ErikCH ErikCH temporarily deployed to ci December 21, 2021 20:05 Inactive
@ErikCH ErikCH temporarily deployed to ci December 21, 2021 20:05 Inactive
@ErikCH ErikCH temporarily deployed to ci December 21, 2021 20:05 Inactive
@ErikCH ErikCH merged commit ea98bea into main Dec 21, 2021
@ErikCH ErikCH deleted the tsup-config-typo branch December 21, 2021 21:46
@github-actions github-actions bot mentioned this pull request Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants