Authenticator: fix issue where phone_number validation fails #1014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an issue where 2223334444 phone number format fails when there are other form validation errors such as a short password. The fix ensures that formValues.phone_number is not mutated on each signUp call.
🦋 Changeset detectedLatest commit: 86ca9ce The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically being deployed by Amplify Hosting (learn more). |
ericclemmons
approved these changes
Dec 17, 2021
ericclemmons
approved these changes
Dec 17, 2021
| if (formValues.phone_number) { | ||
| formValues.phone_number = |
There was a problem hiding this comment.
The fix ensures that formValues.phone_number is not mutated on each signUp call.
You said it! Mutations are a huge risk!
I'm redoing #911, but that fixes phone_number to always be a computed value in the form so that this logic doesn't need to live in the machine.
Merged
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Closes #1008
Description of changes:
This fixes an issue where phone number validation fails for country code
+1when there are other form validation errors such as a short password. This causes thephone_numbervalue to be mutated, andNnumber of+1's to be appended (where N is number of times the form has been submitted):The fix ensures that
formValues.phone_numberis not mutated on eachsignUpcall.By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.