Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Camel Case configuration for Category Names, and Plugin keys and fields #162

Merged
merged 5 commits into from
Nov 26, 2019
Merged

Camel Case configuration for Category Names, and Plugin keys and fields #162

merged 5 commits into from
Nov 26, 2019

Conversation

lawmicha
Copy link
Contributor

@lawmicha lawmicha commented Nov 26, 2019 •
edited
Loading

Updated configuration key's to camel casing.

Predictions

  • "awsPredictionsPlugin" from "AWSPredictionsPlugin"
  • fields already camel case

Analytics

"awsPinpointAnalyticsPlugin" from "AWSPinpointAnalyticsPlugin"

  • all fields camelCase

Storage

  • "awsS3StoragePlugin" from "AWSS3StoragePlugin"
  • rename storage access level from public to guest
  • all fields camelCase
  • had troubles running the integration tests, did not know how to change "Target Application" to "Host Application" so recreated the target, which is why there are a bunch of new files, but they're pretty much the same.

API

  • "awsAPIPlugin" from "AWSAPICategoryPlugin"
  • all fields camelCase

DataStore

  • "awsDataStoreCategoryPlugin" from "AWSDataStoreCategoryPlugin"

AmplifyCore

  • category names are now camelCase
  • Hub: awsHubPlugin from AWSHubPlugin

#96

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@lawmicha lawmicha self-assigned this Nov 26, 2019
@lawmicha lawmicha requested review from royjit and palpatim November 26, 2019 01:06
@lawmicha lawmicha added analytics Issues related to the Analytics category api Issues related to the API category datastore Issues related to the DataStore category predictions Issues related to the Predictions category storage Issues related to the Storage category core Amplify Core components labels Nov 26, 2019
palpatim
palpatim approved these changes Nov 26, 2019
View reviewed changes
Copy link
Member

@palpatim palpatim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, otherwise LGTM

Amplify/Categories/Storage/Operation/Request/StorageGetDataRequest.swift Outdated
@@ -37,8 +37,8 @@ public extension StorageGetDataRequest {
// TODO: transferAcceleration should be in pluginOptions
// https://docs.aws.amazon.com/AmazonS3/latest/dev/transfer-acceleration.html

// TODO: Is `public` the right default?
public init(accessLevel: StorageAccessLevel = .public,
// TODO: Is `guest` the right default?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here and throughout: We can remove this TODO now that we've discussed w/broader team. If we get customer feedback about changing it we'll do it then

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removing

AmplifyPlugins/API/AWSAPICategoryPlugin/AWSAPICategoryPlugin.swift
@@ -12,7 +12,7 @@ final public class AWSAPICategoryPlugin: NSObject, APICategoryPlugin {

/// The unique key of the plugin within the API category.
public var key: PluginKey {
Copy link
Member

@palpatim palpatim Nov 26, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do also we think it's worth renaming the class, Pod, module, etc? (For a future PR, not in this PR)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes this makes sense #165 this seems like a P0 thing as well

@lawmicha lawmicha mentioned this pull request Nov 26, 2019
Closed
@lawmicha lawmicha merged commit ff602bb into master Nov 26, 2019
@palpatim palpatim deleted the lawmicha/camel-case-config branch December 3, 2019 17:21
harsh62 added a commit that referenced this pull request Nov 22, 2024
@harsh62
feat(auth): adding passwordless sign in preferred flows (#162)
56b31e0 
* feat(auth): add passwordless preferred flow

* adding confirm device and device srp flows to user auth

* update message

* worked on review comments

* update
harsh62 added a commit that referenced this pull request Nov 25, 2024
@harsh62 @sebaland @thisisabhash
Merge pull request #3920 from aws-amplify/passwordless
edd2aa7 
* feat(auth): adding support for email mfa (#3892)

* feat(auth): adding support for email mfa

* fix swift lint warning

* worked on a review comment

* adding integration tests wave 1

* integration tests wave 2

* integration tests wave 3

* Add test setup instructions wave 4

* Add edge case

* update readme to include graphQL details

* chore: initial commit to add sdk with passwordless models

* chore: model update

* feat(Auth): Adding WebAuthn APIs (#153)

* feat(Auth): Adding List WebAuthn API

* feat(Auth): Adding associate and delete WebAuthn credentials APIs

* Addding missing transports array in the credentials payload

* Adding friendlyName to AuthWebAuthnCredential

* Adding excludedCredentials to avoid multiple PassKeys for the same device

* Adding pagination support in the list API

* Renaming CredentialPayload to CredentialRegistrationPayload

* Addressing PR comments

* feat(auth): add passwordless sign with otp (#151)

* feat(auth): add passwordless OTP implementation

* add fallback password and password srp flows

* add web auth n states

* modifying states

* feat(Auth): Adding WebAuthn support to signIn and confirmSignIn APIs (#155)

* feat(auth): add passwordless OTP implementation

* add fallback password and password srp flows

* add web auth n states

* modifying states

* feat(Auth): Implementing signIn with WebAuthn

* Adding support for a presentation anchor in sign in and confirm sign in options

* Fixing errors

* Addressing PR comments

* fix build error

---------

Co-authored-by: Harshdeep Singh <6162866+harsh62@users.noreply.github.com>

* fix: Fixing build issue when iOS 18/macOS 15 are not installed

* feat(WebAuthn): Adding support for retrying a confirmSignIn with WebAuthn request, if the first one fails (#158)

* feat(auth): add support for passwordless sign up and auto sign in (#160)

* add autoSignIn() category API definitions (#152)

* add autoSignIn() category API definitions

* add sign up step for auto sign in

* add state machine changes for autoSignIn() and signUp() (#154)

* add autoSignIn() category API definitions

* add sign up step for auto sign in

* add state machine changes

* add events and update resolvers

* update sign up events and resolvers

* add updates to resolver for auto sign in

* update confirm sign up flow and debug code

* Address review comments

---------

Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>

* update auto sign state machine events and resolver (#157)

* update auto sign state machine events and resolver

* Address review comments

* update sign up and auto sign in unit tests (#159)

* update sign up and auto sign in unit tests

* add auto sign in tests and refactor existing tests

* Add more service error tests

* Address review changes

---------

Co-authored-by: Harsh <6162866+harsh62@users.noreply.github.com>

* chore: fix building of unit tests after sign up rebase

* feat(auth): adding passwordless sign in preferred flows (#162)

* feat(auth): add passwordless preferred flow

* adding confirm device and device srp flows to user auth

* update message

* worked on review comments

* update

* chore(auth): add more auto sign in and sign up state machine/e2e unit tests (#161)

* chore(auth): add more auto sign in and sign up state machine/e2e unit tests

* Address review comments

* chore: updated SDK and models

* chore: update integration test host app

* fix: Fixing build errors in watchOS/tvOS due to missing prechecks.

* feat(auth): adding an initial passwordless integration test with resources defined (#163)

* chore: update no-auth API's in the resolver

* chore: Updating to the renamed WebAuthn APIs (#164)

* chore: Updating to the renamed WebAuthn APIs

* Fixing unit tests

* chore: Adding unit tests for the WebAuthn APIs Tasks (#165)

* test: Adding AssociateWebAuthn unit tests

* test: Adding ListWebAuthnCredentials unit tests

* test: Adding DeleteWebAuthnCredential unit tests

* chore: simplifying how webauthn errors are handled

* adressing PR comments

* chore(auth): add integration tests for passwordless signup and auto sign in (#166)

* chore(auth): add integration tests for passwordless signup and auto sign in

* remove unused code

* refactor code

* chore: add integration tests for sign in flows (#168)

* chore: add integration tests for sign in flows

* Update AuthSignInWithPasswordUsingUserAuthTests.swift

* Add more integration tests

* update

* chore: update sdk to use the latest models

* test: Adding integration tests for WebAuthn APIs (#169)

* test: Adding integration tests for WebAuthn APIs

* chore: Adding webauthn integration workflow

* Refactoring the code to remove unnecesary waits and make it more easy to read

* fix: Fixing service errors being reported as .unknown when sign in fails (#170)

* fix: Fixing service errors being reported as .unknown when sign in fails. Also adding proper WebAuthn cases to the AWSCognitoAuthError enum.

* addressing PR comment

* fix(auth): fix resolvers and tasks for auto sign in when state machine is in signing in state (#172)

* fix(auth): fix resolvers and tasks for auto sign in when state machine is in signin in state

* fix indentation

* feat: Adding visionOS support to the WebAuthn APIs (#171)

* chore: using the latest version aws sdk

* chore: update changes needed for the sdk updated

* chore: fix swiftlint errors (#3921)

* chore: running passwordless integration tests on GEN2 backend

* chore: update test target for watchOS

* chore: fix OTP integration tests

* chore: update more integration tests

---------

Co-authored-by: Sebastian Villena <97059974+ruisebas@users.noreply.github.com>
Co-authored-by: Abhash Kumar Singh <thisisabhash@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@palpatim palpatim palpatim approved these changes

@royjit royjit Awaiting requested review from royjit

Assignees

@lawmicha lawmicha

Labels
analytics Issues related to the Analytics category api Issues related to the API category core Amplify Core components datastore Issues related to the DataStore category predictions Issues related to the Predictions category storage Issues related to the Storage category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lawmicha @palpatim