Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Owner-based auth based on IdentityClaim #485

Closed
lawmicha opened this issue May 26, 2020 · 3 comments
Closed

Owner-based auth based on IdentityClaim #485

lawmicha opened this issue May 26, 2020 · 3 comments
Assignees
@wooj2
Labels
datastore Issues related to the DataStore category feature-request Request a new feature pending-triage Issue is pending triage

Comments

@lawmicha
Copy link
Contributor

Currently, a developer using Auth directive can set their own identityClaim which determines which value to use as the owner. DataStore uses Auth.getCurrentUser and uses the username as owner. This feature is to support different identityClaims like cognito sub or something else.

The impact of not doing this is no support for custom identityClaims.
@lawmicha lawmicha added the datastore Issues related to the DataStore category label May 26, 2020
@lawmicha lawmicha mentioned this issue May 26, 2020
Merged
@drochetti drochetti added feature-request Request a new feature pending-triage Issue is pending triage and removed enhancement labels Jun 24, 2020
@lawmicha lawmicha mentioned this issue Jul 2, 2020
Merged
@palpatim
Copy link
Member

Code snippet for reference https://github.com/aws-amplify/amplify-ios/blob/4cb4423a6eb3d46dc0caf4bf55392384b0e4acc8/AmplifyPlugins/DataStore/AWSDataStoreCategoryPlugin/Sync/SubscriptionSync/IncomingAsyncSubscriptionEventPublisher.swift#L159-L165

palpatim added a commit that referenced this issue Aug 19, 2020
@palpatim
chore: Remove identityClaim TODO
d1ad897 
Tracked in #485
@wooj2 wooj2 self-assigned this Oct 1, 2020
@wooj2 wooj2 mentioned this issue Oct 1, 2020
Merged
@lawmicha
Copy link
Contributor Author

lawmicha commented Oct 5, 2020 •
edited
Loading

to support usernames by different sign in methods like email and phone, Android's implementation parses the JWT token #794 (comment)

@wooj2
Copy link
Contributor

wooj2 commented Oct 10, 2020

This PR should resolve this issue:
#813

@wooj2 wooj2 closed this as completed Oct 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wooj2 wooj2

Labels
datastore Issues related to the DataStore category feature-request Request a new feature pending-triage Issue is pending triage
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@palpatim @drochetti @lawmicha @wooj2