Return promise in signIn

[janoist1]

Issue #, if available: SignIn.signIn does not return the Promise got from Auth.signIn. This is not consistent with the React Web version which does return it.

Description of changes: Return promise.

[janoist1]

Please someone at least react to this...

[codecov]

Codecov Report

Merging #5021 into master will not change coverage by %.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #5021   +/-   ##
=======================================
  Coverage   73.21%   73.21%           
=======================================
  Files         193      193           
  Lines       11441    11441           
  Branches     2218     2302   +84     
=======================================
  Hits         8377     8377           
+ Misses       2916     2900   -16     
- Partials      148      164   +16     

Impacted Files	Coverage Δ
packages/auth/src/OAuth/OAuth.ts	48.12% <0.00%> (ø)
packages/datastore/src/sync/outbox.ts	25.00% <0.00%> (ø)
packages/datastore/src/storage/storage.ts	67.59% <0.00%> (ø)
packages/core/src/OAuthHelper/GoogleOAuth.ts	31.25% <0.00%> (ø)
packages/xr/src/Providers/SumerianProvider.ts	47.55% <0.00%> (ø)
packages/core/src/OAuthHelper/FacebookOAuth.ts	34.09% <0.00%> (ø)
packages/datastore/src/sync/processors/sync.ts	18.05% <0.00%> (ø)
...ackages/datastore/src/storage/adapter/indexeddb.ts	73.26% <0.00%> (ø)
...ackages/pubsub/src/Providers/AWSAppSyncProvider.ts	66.66% <0.00%> (ø)
...ages/datastore/src/sync/processors/subscription.ts	43.91% <0.00%> (ø)
... and 2 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf7b72...7ee61db. Read the comment docs.

[janoist1]

No one can review a single line commit in 3 weeks? 😷

[manueliglesias]

Hi @janoist1

We are reviewing and testing your PR today, thank you for the contribution!

[Ashish-Nanda]

@janoist1 Thank you for your contribution!

I've tested and approved your PR, and the changes will be available in the next release.

[github-actions]

This pull request has been automatically locked since there hasn't been any recent activity after it was closed. Please open a new issue for related bugs.

Looking for a help forum? We recommend joining the Amplify Community Discord server *-help channels or Discussions for those types of questions.