Added Exceptions to Temporal #825
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richardmcclellan
suggested changes
Sep 14, 2020
aws-api-appsync/src/test/java/com/amplifyframework/core/model/temporal/TemporalDateTest.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/core/model/temporal/Temporal.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/TemporalDeserializers.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/TemporalDeserializers.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/TemporalDeserializers.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/test/java/com/amplifyframework/core/model/temporal/TemporalTimeTest.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/core/model/temporal/Temporal.java
Outdated
Show resolved
Hide resolved
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/TemporalDeserializers.java
Show resolved
Hide resolved
There was a problem hiding this comment.
Looking better! It looks like there some of the existing tests are failing. Now that the Temporal constructors can throw an IllegalArgumentException, you probably need to add throws IllegalArgumentException to any existing test method signatures that use them.
|
Now I'm able to fix all issues |
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/TemporalDeserializers.java
Outdated
Show resolved
Hide resolved
…poralDeserializers.java
aws-api-appsync/src/main/java/com/amplifyframework/api/aws/TemporalDeserializers.java
Outdated
Show resolved
Hide resolved
…poralDeserializers.java
|
Thanks for helping a lot |
Thanks so much for contributing! |
My Pleasure |
aws-api-appsync/src/main/java/com/amplifyframework/core/model/temporal/Temporal.java
Outdated
Show resolved
Hide resolved
richardmcclellan
approved these changes
Sep 15, 2020
There was a problem hiding this comment.
I'm going to merge this now, so we can get it into our next release. Thanks again @hellosagar!
|
Give me a second sir let me made those doc changes |
|
Push done for doc changes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.