fix(auth): throw correct auth exception for code mismatch #1370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
changxu0306
suggested changes
Jun 10, 2021
There was a problem hiding this comment.
Overall it looks good. But I think similar changes should also be made in the onError() callback for fetchAuthSession(), resetPassword(), confirmResetPassword(), updatePassword(), fetchUserAttributes(), etc. in AWSCognitoAuthPlugin. By doing that, we won't need to fix this class again if similar issues is reported in the future.
...nito/src/main/java/com/amplifyframework/auth/cognito/util/CognitoAuthExceptionConverter.java
Outdated
Show resolved
Hide resolved
...nito/src/main/java/com/amplifyframework/auth/cognito/util/CognitoAuthExceptionConverter.java
Show resolved
Hide resolved
…to/util/CognitoAuthExceptionConverter.java Co-authored-by: Chang Xu <42978935+changxu0306@users.noreply.github.com>
changxu0306
suggested changes
Jun 11, 2021
core/src/main/java/com/amplifyframework/auth/AuthException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/AuthException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/AuthException.java
Outdated
Show resolved
Hide resolved
core/src/main/java/com/amplifyframework/auth/AuthException.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Chang Xu <42978935+changxu0306@users.noreply.github.com>
Co-authored-by: Chang Xu <42978935+changxu0306@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available: #1102
Description of changes:
Throw AuthException with correct message and recovery suggestion mapped to Cognito exception instead of generic exception.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.