Feature/payment option interface #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
Notes:
Added all the methods in the cash-on-delivery payment option class (identifier, name, process, render, etc) to the interface. New methods are 'requiresAddress' and 'address' methods which are necessary to handle billing address attachment with most card payment gateways. Another method 'syncOrder' is used to sync a payment transaction record with an order.
I am working on a card payment module for 'Merchant Warrior' payment gateway and would prefer to get this merged in first so that we have the right groundwork for further payment options. Here is a link to the CardPayment class i am working on https://github.com/Sharnw/avored-merchant-warrior/blob/develop/src/CardPayment.php (for reference)
edit:
Just realised i created initial branch from master instead of dev. Shouldn't be a problem as the 2 extra commits are just you merging dev into master, but if it is a problem let me know and i will recreate the branch & PR from dev.