Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't submit form on autocomplete #3554

Merged
merged 1 commit into from
Dec 23, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #3553

Problem:
Autocomplete interactions were inadvertently triggering the submit action on the form controller. This action is intended to be triggered only by the specified Stimulus Keyboard events:
keydown.ctrl+enter->form#submit and keydown.meta+enter->form#submit.

Solution:
This PR introduces a guard clause to ensure that the event.key property is present before proceeding with the form submission. This effectively prevents unintended triggers caused by autocomplete behavior.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Dec 23, 2024
@github-actions github-actions bot added the Fix label Dec 23, 2024
Copy link

codeclimate bot commented Dec 23, 2024

Code Climate has analyzed commit 24241ce and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit fdc7856 into main Dec 23, 2024
20 of 21 checks passed
@Paul-Bob Paul-Bob deleted the fix/dont_submit_form_on_autocomplete branch December 23, 2024 06:11
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Starting with avo 3.15.4 Chrome autofill submits the form
1 participant