UI Fix: Tables become horizontally scrollable after clicking "Select All" #3537
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 9147e95 and detected 0 issues on this pull request. View more on Code Climate. |
|
Thanks for looking into this @Shub3am! There was an issue with your original approach:
I just pushed a commit that fixes this issue ☝️ |
This approach removes the margin size from the full width
|
@Shub3am I added another commit that computes the full width minus Thanks again for submitting this contribution! I took over to ensure it gets included in a patch release today. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UI Fix: Tables become horizontally scrollable after clicking "Select All"
Description
Changed The Width of the Selector Container to 95% instead of full-width which causes it to overflow unnecessarily on larger screens.
Fixes #3509
Checklist:
Screenshots & recording
Screen.Recording.2024-12-17.at.12.01.26.PM.mov
Manual review steps
Tested Visually on various screen sizes of different types: mobile, tablet and desktop screens ( upto 2k )