Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix appraisal #3504

Merged
merged 9 commits into from
Dec 10, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/feature-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,9 @@ jobs:
- '6.1'
- '7.1'
- '8.0'
exclude:
- ruby: '3.1.4'
rails: '8.0'
runs-on: ubuntu-latest

env:
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/system-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,9 @@ jobs:
- '6.1'
- '7.1'
- '8.0'
exclude:
- ruby: '3.1.4'
rails: '8.0'
runs-on: ubuntu-latest

env:
Expand Down
16 changes: 5 additions & 11 deletions Appraisals
Original file line number Diff line number Diff line change
@@ -1,20 +1,14 @@
["3.1.4", "3.3.0"].each do |ruby_version|
["6.1", "7.1", "7.2.0.beta2"].each do |rails_version|
["6.1", "7.1", "8.0"].each do |rails_version|
# Rails 8 require ruby >= 3.2.0
next if ruby_version == "3.1.4" && rails_version == "8.0"

appraise "rails-#{rails_version}-ruby-#{ruby_version}" do
gem "psych", "< 4"
gem "rails", "~> #{rails_version}"
gem "activestorage", "~> #{rails_version}"
gem "activestorage"
gem "acts-as-taggable-on"
end
end

# TODO: we'll probably have to remove these when Rails 8 is released
appraise "rails-8.0-ruby-#{ruby_version}" do
gem "psych", "< 4"
gem "rails", github: "rails/rails", branch: "main"
gem "activestorage", github: "rails/rails", branch: "main"

# Temporary Rails 8 support
gem "acts-as-taggable-on", github: "avo-hq/acts-as-taggable-on"
end
end
3 changes: 1 addition & 2 deletions Gemfile
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,7 @@ gem "active_median"

gem 'acts_as_list'

# gem 'acts-as-taggable-on', '~> 10.0'
gem "acts-as-taggable-on"
gem "acts-as-taggable-on", "~> 12.0"

gem "bundler-integrity", "~> 1.0"

Expand Down
2 changes: 1 addition & 1 deletion Gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -669,7 +669,7 @@ DEPENDENCIES
active_link_to
active_median
activestorage (>= 8.0.0)
acts-as-taggable-on
acts-as-taggable-on (~> 12.0)
acts_as_list
actual_db_schema
addressable
Expand Down
6 changes: 3 additions & 3 deletions gemfiles/rails_6.1_ruby_3.1.4.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ GEM
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
acts-as-taggable-on (10.0.0)
activerecord (>= 6.1, < 8)
activerecord (>= 6.1, < 7.2)
acts_as_list (1.2.2)
activerecord (>= 6.1)
activesupport (>= 6.1)
Expand Down Expand Up @@ -363,7 +363,7 @@ GEM
mini_histogram (0.3.1)
mini_magick (4.13.2)
mini_mime (1.1.5)
minitest (5.25.1)
minitest (5.25.4)
monetize (1.13.0)
money (~> 6.12)
money (6.19.0)
Expand Down Expand Up @@ -630,7 +630,7 @@ GEM
xpath (3.2.0)
nokogiri (~> 1.8)
yard (0.9.37)
zeitwerk (2.6.18)
zeitwerk (2.7.1)

PLATFORMS
arm64-darwin-23
Expand Down
6 changes: 3 additions & 3 deletions gemfiles/rails_6.1_ruby_3.3.0.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ GEM
tzinfo (~> 2.0)
zeitwerk (~> 2.3)
acts-as-taggable-on (10.0.0)
activerecord (>= 6.1, < 8)
activerecord (>= 6.1, < 7.2)
acts_as_list (1.2.2)
activerecord (>= 6.1)
activesupport (>= 6.1)
Expand Down Expand Up @@ -337,7 +337,7 @@ GEM
mini_histogram (0.3.1)
mini_magick (4.13.2)
mini_mime (1.1.5)
minitest (5.25.1)
minitest (5.25.4)
monetize (1.13.0)
money (~> 6.12)
money (6.19.0)
Expand Down Expand Up @@ -603,7 +603,7 @@ GEM
xpath (3.2.0)
nokogiri (~> 1.8)
yard (0.9.37)
zeitwerk (2.6.18)
zeitwerk (2.7.1)

PLATFORMS
arm64-darwin-23
Expand Down
15 changes: 8 additions & 7 deletions gemfiles/rails_7.1_ruby_3.1.4.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,9 @@ GEM
minitest (>= 5.1)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
acts-as-taggable-on (10.0.0)
activerecord (>= 6.1, < 8)
acts-as-taggable-on (12.0.0)
activerecord (>= 7.1, < 8.1)
zeitwerk (>= 2.4, < 3.0)
acts_as_list (1.2.2)
activerecord (>= 6.1)
activesupport (>= 6.1)
Expand Down Expand Up @@ -357,7 +358,7 @@ GEM
listen (3.9.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
logger (1.6.1)
logger (1.6.2)
loofah (2.23.1)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -376,7 +377,7 @@ GEM
mini_histogram (0.3.1)
mini_magick (4.13.2)
mini_mime (1.1.5)
minitest (5.25.1)
minitest (5.25.4)
monetize (1.13.0)
money (~> 6.12)
money (6.19.0)
Expand Down Expand Up @@ -551,7 +552,7 @@ GEM
simplecov (>= 0.22.0)
tty-which (~> 0.5.0)
virtus (~> 2.0)
securerandom (0.3.1)
securerandom (0.4.0)
sexp_processor (4.17.2)
simplecov (0.22.0)
docile (~> 1.1)
Expand Down Expand Up @@ -613,7 +614,7 @@ GEM
thor (1.3.2)
thread_safe (0.3.6)
tilt (2.4.0)
timeout (0.4.1)
timeout (0.4.2)
tty-which (0.5.0)
turbo-rails (2.0.10)
actionpack (>= 6.0.0)
Expand Down Expand Up @@ -651,7 +652,7 @@ GEM
xpath (3.2.0)
nokogiri (~> 1.8)
yard (0.9.37)
zeitwerk (2.6.18)
zeitwerk (2.7.1)

PLATFORMS
arm64-darwin-23
Expand Down
15 changes: 8 additions & 7 deletions gemfiles/rails_7.1_ruby_3.3.0.gemfile.lock
Original file line number Diff line number Diff line change
Expand Up @@ -100,8 +100,9 @@ GEM
minitest (>= 5.1)
securerandom (>= 0.3)
tzinfo (~> 2.0, >= 2.0.5)
acts-as-taggable-on (10.0.0)
activerecord (>= 6.1, < 8)
acts-as-taggable-on (12.0.0)
activerecord (>= 7.1, < 8.1)
zeitwerk (>= 2.4, < 3.0)
acts_as_list (1.2.2)
activerecord (>= 6.1)
activesupport (>= 6.1)
Expand Down Expand Up @@ -331,7 +332,7 @@ GEM
listen (3.9.0)
rb-fsevent (~> 0.10, >= 0.10.3)
rb-inotify (~> 0.9, >= 0.9.10)
logger (1.6.1)
logger (1.6.2)
loofah (2.23.1)
crass (~> 1.0.2)
nokogiri (>= 1.12.0)
Expand All @@ -350,7 +351,7 @@ GEM
mini_histogram (0.3.1)
mini_magick (4.13.2)
mini_mime (1.1.5)
minitest (5.25.1)
minitest (5.25.4)
monetize (1.13.0)
money (~> 6.12)
money (6.19.0)
Expand Down Expand Up @@ -524,7 +525,7 @@ GEM
simplecov (>= 0.22.0)
tty-which (~> 0.5.0)
virtus (~> 2.0)
securerandom (0.3.1)
securerandom (0.4.0)
sexp_processor (4.17.2)
simplecov (0.22.0)
docile (~> 1.1)
Expand Down Expand Up @@ -586,7 +587,7 @@ GEM
thor (1.3.2)
thread_safe (0.3.6)
tilt (2.4.0)
timeout (0.4.1)
timeout (0.4.2)
tty-which (0.5.0)
turbo-rails (2.0.10)
actionpack (>= 6.0.0)
Expand Down Expand Up @@ -624,7 +625,7 @@ GEM
xpath (3.2.0)
nokogiri (~> 1.8)
yard (0.9.37)
zeitwerk (2.6.18)
zeitwerk (2.7.1)

PLATFORMS
arm64-darwin-23
Expand Down
95 changes: 0 additions & 95 deletions gemfiles/rails_7.2.0.beta2_ruby_3.1.4.gemfile

This file was deleted.

Loading
Loading