Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: maintain per_page param in associations #3490

Merged
merged 4 commits into from
Dec 4, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Dec 4, 2024

Description

Fixes #3489

Store per_page on associations making the navigation between associated records a bit smoother.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob self-assigned this Dec 4, 2024
@github-actions github-actions bot added the Fix label Dec 4, 2024
Copy link

codeclimate bot commented Dec 4, 2024

Code Climate has analyzed commit 6a80932 and detected 0 issues on this pull request.

View more on Code Climate.

@johnvtroy
Copy link

Hi @Paul-Bob, what happens next with this fix?

spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
spec/system/avo/tabs_spec.rb Outdated Show resolved Hide resolved
@Paul-Bob
Copy link
Contributor Author

Paul-Bob commented Dec 4, 2024

Hi @Paul-Bob, what happens next with this fix?

Hi @johnvtroy

It will be released soon and the issue will be fixed on 3.15.1

@Paul-Bob Paul-Bob merged commit 9c756d4 into main Dec 4, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/maintain_per_page_param_in_associations branch December 4, 2024 15:10
Copy link
Contributor

github-actions bot commented Dec 4, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagy::OverflowError in Avo::AssociationsController#index expected :page in 1..2; got 3
2 participants