Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: SVG breaks buton in Safari #3397

Merged
merged 2 commits into from
Nov 11, 2024
Merged

fix: SVG breaks buton in Safari #3397

merged 2 commits into from
Nov 11, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Nov 8, 2024 •
edited
Loading

Description

Fixes #3389

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Nov 8, 2024
adrianthedev
adrianthedev commented Nov 8, 2024
View reviewed changes
app/components/avo/button_component.rb
# add the icon height
icon_classes += icon_size_classes
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix was to add pointer-events-none on the SVG element.

@codeclimate CodeClimate
Copy link

codeclimate bot commented Nov 8, 2024 •
edited
Loading

Code Climate has analyzed commit edd30ce and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev requested a review from Paul-Bob November 8, 2024 12:33
@Paul-Bob Paul-Bob merged commit 8868d89 into main Nov 11, 2024
22 checks passed
@Paul-Bob Paul-Bob deleted the fix/svg-brakes-button-in-safari branch November 11, 2024 09:36
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

@giedriusr
Copy link

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Bob Paul-Bob Paul-Bob approved these changes

Assignees
No one assigned
Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Save button icon (floppy disk) issue (on click, doesn't save the record in Safari browser)
3 participants
@adrianthedev @giedriusr @Paul-Bob