Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: support rails authentication generator out of the box #3376

Merged
merged 4 commits into from
Nov 22, 2024

Conversation

adrianthedev
Copy link
Collaborator

@adrianthedev adrianthedev commented Nov 1, 2024

Note

This PR ended up just fixing a few unrelated bugs but produced the knowledge to build up [this guide](https://docs.avohq.io/3.0/guides/rails-authentication-scaffold.html that shows how to support Rails' authentication scaffold.

Description

Fixes #3361

Resources:

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Generate a new Rails 8 app
  2. Run the authentication generator bin/rails generate authentication
  3. check to see if Avo has the sign out button available

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Nov 1, 2024

Code Climate has analyzed commit 2b5f702 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev mentioned this pull request Nov 1, 2024
4 tasks
@adrianthedev adrianthedev requested a review from Paul-Bob November 1, 2024 19:16
@adrianthedev adrianthedev marked this pull request as ready for review November 1, 2024 19:16
@adrianthedev adrianthedev changed the title refactor: support rails authentication out of the box refactor: support rails authentication generator out of the box Nov 4, 2024
@adrianthedev adrianthedev marked this pull request as draft November 4, 2024 09:23
Copy link
Contributor

This PR has been marked as stale because there was no activity for the past 15 days.

@github-actions github-actions bot added the Stale label Nov 22, 2024
@adrianthedev adrianthedev marked this pull request as ready for review November 22, 2024 13:24
@adrianthedev adrianthedev merged commit 49265e8 into main Nov 22, 2024
22 checks passed
@adrianthedev adrianthedev deleted the refactor/support-rails-otb-authentication branch November 22, 2024 14:06
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Integrating Rails 8 authentication with Avo
1 participant