Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have Avo tailwind watcher cover ejected components. #3188

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

cmaxw
Copy link
Contributor

@cmaxw cmaxw commented Aug 23, 2024

Description

I ran the generator to install tailwind for avo. I had an ejected component that wasn't in the config for tailwind to watch. I added the folder where it ejected the component to.

Fixes # (issue)
I haven't submitted an issue.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Eject a component. I had Avo::Views::ResourceShowComponent ejected and modified.
  2. Add a div with tailwind classes in it. I did a button.
  3. You'll see that some of the classes don't apply.
  4. Apply this fix.
  5. You'll see it start working.

Manual reviewer: please leave a comment with output from the test if that's the case.

@cmaxw
Copy link
Contributor Author

cmaxw commented Aug 23, 2024

I'm not sure there are changes needed to the documentation. Can I check that off?

Copy link

codeclimate bot commented Aug 23, 2024

Code Climate has analyzed commit 44935bf and detected 0 issues on this pull request.

View more on Code Climate.

@cmaxw
Copy link
Contributor Author

cmaxw commented Aug 23, 2024

Also not sure if you're testing the tailwind output.

@adrianthedev
Copy link
Collaborator

No, we don't have tests for this generator. ANd we're good on the docs.

Thank you for your contribution!

@adrianthedev adrianthedev merged commit 9a954cb into avo-hq:main Aug 23, 2024
22 checks passed
@Paul-Bob Paul-Bob added the Fix label Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants