fix: check for pagy version #3050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 491dda1 and detected 0 issues on this pull request. View more on Code Climate. |
| @@ -28,7 +28,7 @@ def change_items_per_page_url(option) | |||
| def render? | |||
| return false if discreet_pagination && pagy.pages <= 1 | |||
|
|
|||
| if defined?(@pagy.limit) | |||
| if ::Pagy::VERSION > ::Gem::Version.new("9.0") | |||
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/YodaCondition: Reverse the order of the operands ::Pagy::VERSION > ::Gem::Version.new("9.0").
| @@ -1,6 +1,8 @@ | |||
| require "pagy/extras/trim" | |||
| require "pagy/extras/countless" | |||
| require "pagy/extras/size" | |||
| if ::Pagy::VERSION > ::Gem::Version.new("9.0") | |||
There was a problem hiding this comment.
[rubocop] reported by reviewdog 🐶
[Correctable] Style/YodaCondition: Reverse the order of the operands ::Pagy::VERSION > ::Gem::Version.new("9.0").
|
This PR has been merged into Please check the release guide for more information. |
11 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #3046 (comment)
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.