refactor: Restructure Avo::BaseResource for user customization #2998
Conversation
|
Code Climate has analyzed commit 81bbda4 and detected 0 issues on this pull request. View more on Code Climate. |
e41f27a to
6cb9af7
Compare
There was a problem hiding this comment.
Hei! Thanks for looking into this @Yash-Singh-Pathania !!
Looking good, let's please add some documentation about this, something like we have on controllers
A brief paragraph and an example with a method that can be reused on all resources should be enough.
@Yash-Singh-Pathania are you disponible to write the docs? (https://github.com/avo-hq/docs.avohq.io)
lib/avo/resources/base.rb
Outdated
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Changes made added the empty line sorry for that , also @Paul-Bob would be totally down to write the docs could you just guide me a the repository from what I see is different , so do I raise a seprate pr and link it to this pr ?
But yeah totally down to writing it .
lmk
Thanks
There was a problem hiding this comment.
Yes, this is the docs repo https://github.com/avo-hq/docs.avohq.io
You can add a PR there and link it on this PR description, something like:
...
Checklist
...
- [x] I have made corresponding changes to the [documentation](https://github.com/avo-hq/avodocs)
- Link to docs here <--
...
Let me know if you need any help setting up the docs repo
Thank you!
added blank line in base.rb
|
BTW let's ignore the lint on this PR, let's keep the same code, we can lint it later |
|
@Paul-Bob added empty lines at the end without making other changes, regarding lining. Thanks for the help, but I got the docs set up and am adding a pull request for the same. Thanks. |
|
@Paul-Bob is there anything else needed on this pr ? |
|
Hey @Yash-Singh-Pathania I'll do a more careful review tomorrow, looking good! Thank you! |
Description
Fixes #2959
Checklist:
Screenshots & recording
Manual review steps