-
-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: drop httparty dependency #2942
Conversation
Code Climate has analyzed commit 6db8017 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Have you by any chance tested some of those exceptions by hand to see if they will be caught properly?
Tested |
TODO: test |
This PR has been merged into Please check the release guide for more information. |
@@ -0,0 +1,18 @@ | |||
module Avo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am seeing an uninitialized constant Net::HTTP
when I start a rails server with rails 3.3.4 and avo 3.10.6. Do we need to add the following ?
require "net/http"
When I add this to the top of avo.rb
initialiser the problem is resolved.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I've been seeing that as well. We'll add it to the initial file as well.
Description
Fixes #2899
Checklist: