Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tags delimiters #2932

Merged
merged 2 commits into from
Jul 3, 2024
Merged

fix: tags delimiters #2932

merged 2 commits into from
Jul 3, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jul 3, 2024

Description

Fixes #2922

Properly apply delimiters on the tags field.

Format tags' param value using the first delimiter then split them using the same delimiter.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Jul 3, 2024
@Paul-Bob Paul-Bob requested a review from adrianthedev July 3, 2024 10:40
@Paul-Bob Paul-Bob self-assigned this Jul 3, 2024
Copy link

codeclimate bot commented Jul 3, 2024

Code Climate has analyzed commit d534357 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 3cbaae8 into main Jul 3, 2024
21 checks passed
@Paul-Bob Paul-Bob deleted the fix/tags_delimiters branch July 3, 2024 12:45
Copy link
Contributor

github-actions bot commented Jul 3, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Field as: :tags adding custom delimiter ; doesn't work
1 participant