Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: go back button after changing tabs #2896

Merged
merged 3 commits into from
Jun 27, 2024
Merged

fix: go back button after changing tabs #2896

merged 3 commits into from
Jun 27, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Jun 26, 2024

Description

Fixes an issue where after changing tab and clicking create / show / edit inside that tab the browser back button would not work anymore.

Found the solution on this thread

First approach solution (obsolete)

Not sure whats the exact cause of the issue but I found this 2 related threads where @lorint points to this solution.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Jun 26, 2024
@Paul-Bob Paul-Bob requested a review from adrianthedev June 26, 2024 14:44
@Paul-Bob Paul-Bob self-assigned this Jun 26, 2024
@Paul-Bob
Copy link
Contributor Author

Let's not merge this one yet

Copy link

codeclimate bot commented Jun 26, 2024

Code Climate has analyzed commit 9c3c384 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob changed the title fix: go back button fix: go back button after changing tabs Jun 27, 2024
@Paul-Bob Paul-Bob merged commit 8436b09 into main Jun 27, 2024
27 checks passed
@Paul-Bob Paul-Bob deleted the fix/go_back_button branch June 27, 2024 15:58
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant