Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: wrong for_attribute selection #2873

Merged
merged 1 commit into from
Jun 19, 2024
Merged

fix: wrong for_attribute selection #2873

merged 1 commit into from
Jun 19, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Fixes an issue where the for_attribute was not taken into consideration.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@github-actions github-actions bot added the Fix label Jun 18, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 48e915b and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev requested a review from Paul-Bob June 18, 2024 20:25
@adrianthedev adrianthedev merged commit 24b2ee1 into main Jun 19, 2024
23 of 28 checks passed
@adrianthedev adrianthedev deleted the fix/valid-for-attribute-setting branch June 19, 2024 06:11
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Paul-Bob Paul-Bob Awaiting requested review from Paul-Bob

Assignees
No one assigned
Labels
Fix
Projects
Issues
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@adrianthedev