Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to record support to belongs to field #2870

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

krystof-k
Copy link
Contributor

@krystof-k krystof-k commented Jun 18, 2024

Description

This adds support for link_to_record to belongs_to field, meaning on index view it will link to the record instead of the associated record.

Closes already closed #2689.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

  1. Step 1
  2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

Copy link

codeclimate bot commented Jun 18, 2024

Code Climate has analyzed commit 4fa11d1 and detected 1 issue on this pull request.

Here's the issue category breakdown:

Category Count
Complexity 1

View more on Code Climate.

@krystof-k
Copy link
Contributor Author

I have no idea why the test is failing but it should work… I will update the docs when this is merged.

@krystof-k
Copy link
Contributor Author

Yeah, of course it is failing because it has the link to enabled… I'll try to fix it.

@krystof-k krystof-k marked this pull request as draft June 19, 2024 06:21
@krystof-k krystof-k marked this pull request as ready for review June 19, 2024 07:31
@Paul-Bob
Copy link
Contributor

Paul-Bob commented Jul 2, 2024

Thanks for looking into this @krystof-k the PR looks good!

@Paul-Bob Paul-Bob merged commit 94af774 into avo-hq:main Jul 2, 2024
20 of 27 checks passed
@krystof-k krystof-k deleted the add-link-to-belongs-to branch July 2, 2024 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

link_to_record should override link to association or throw warning
2 participants