Action list dividers with labels

[gabrielgiroe1]

Description

Fixes #2672
Test for divider in actions_list in show_controls

Checklist:

• I have performed a self-review of my own code
• I have commented my code, particularly in hard-to-understand areas
• I have made corresponding changes to the documentation
• I have added tests that prove my fix is effective or that my feature works

Screenshots & recording

Manual review steps

1. Step 1
2. Step 2

Manual reviewer: please leave a comment with output from the test if that's the case.

[codeclimate]

Code Climate has analyzed commit bc5fef3 and detected 0 issues on this pull request.

View more on Code Climate.

[adrianthedev]

Good job to get it to this stage.

Let's add tests to check the following:

• divider works in the def actions method
• divider works in actions_list in show_controls
• test for a divider with and without label

[adrianthedev]

It's getting close to merging.

I left a question and some feedback about changing the specs.

[adrianthedev]

We don't need to parse the response like so with Nokogiri. capybara/rspec should have something already.

expect(page).to have SOMETHING

within(find("SOME_SELECTOR")) do
  find("SOMETHING_ELSE")
end

Please check other feature tests.

Also, let's ensure the dividers and actions are in order. So we're not checking just for presence on the page.

This is a good resource aboout how to write better specs. It doesn't necesarily have guides on selectors, but you can see some best practices.

[adrianthedev]

Why would the label be a hash?

[gabrielgiroe1]

Right now it is like this:

action
=> #<Avo::Divider:0x000000016aaf5fa8 @label={:label=>"Other actions"}, @view="index">
>> action.label
=> {:label=>"Other actions"}

[github-actions]

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.