fix: add model-unrelated errors to alerts #2813
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 4cb801c and detected 1 issue on this pull request. Here's the issue category breakdown:
View more on Code Climate. |
|
This PR has been merged into Please check the release guide for more information. |
Paul-Bob
reviewed
Jun 17, 2024
Comment on lines
+234
to
+241
| @errors = @errors.reject { |error| exception_message.include? error } | ||
| end | ||
|
|
||
| # Figure out if we have to output the exception_message | ||
| # Usually it means that it's not a validation error but something else | ||
| if exception_message.present? | ||
| exception_is_validation = @errors.select { |error| exception_message.include? error }.present? | ||
| end |
There was a problem hiding this comment.
Since this code
@errors = @errors.reject { |error| exception_message.include? error }runs before this one
exception_is_validation = @errors.select { |error| exception_message.include? error }.present?will the second one ever be true?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The create failing action already has a
turbo_streamresponse.This PR adds it to the update action as well.
We also add any exception error to the response.
Checklist: