-
-
Notifications
You must be signed in to change notification settings - Fork 276
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add erb_lint #2794
chore: add erb_lint #2794
Conversation
Code Climate has analyzed commit ad279a4 and detected 0 issues on this pull request. View more on Code Climate. |
spec/system/avo/select_all_spec.rb
Outdated
expect(page).to have_css('span.page.active', text: '1') | ||
expect(page).to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).to have_css('.current', text: '1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).to have_css('span.page.active', text: '1') | ||
expect(page).to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).to have_css('.current', text: '1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).to have_css('.current', text: '1') | ||
expect(page).to have_css('a[data-turbo-frame]', text: '2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).to have_css('.current', text: '1') | ||
expect(page).to have_css('a[data-turbo-frame]', text: '2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).not_to have_css('span.page.active', text: '1') | ||
expect(page).not_to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).not_to have_css('.current', text: '1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).not_to have_css('span.page.active', text: '1') | ||
expect(page).not_to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).not_to have_css('.current', text: '1') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).not_to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).not_to have_css('.current', text: '1') | ||
expect(page).not_to have_css('a[data-turbo-frame]', text: '2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
spec/system/avo/select_all_spec.rb
Outdated
expect(page).not_to have_css('span.page', text: '2') | ||
within("nav.pagy.nav") do | ||
expect(page).not_to have_css('.current', text: '1') | ||
expect(page).not_to have_css('a[data-turbo-frame]', text: '2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.
This PR has been merged into Please check the release guide for more information. |
Description
Adds
erb_lint
check.Checklist: