Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add erb_lint #2794

Merged
merged 6 commits into from
May 22, 2024
Merged

chore: add erb_lint #2794

merged 6 commits into from
May 22, 2024

Conversation

adrianthedev
Copy link
Collaborator

Description

Adds erb_lint check.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

Unverified

This user has not yet uploaded their public signing key.
@github-actions github-actions bot added the Chore label May 22, 2024
Copy link

codeclimate bot commented May 22, 2024

Code Climate has analyzed commit ad279a4 and detected 0 issues on this pull request.

View more on Code Climate.

@adrianthedev adrianthedev changed the title chore: add erblint chore: add erb_lint May 22, 2024
expect(page).to have_css('span.page.active', text: '1')
expect(page).to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).to have_css('.current', text: '1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).to have_css('span.page.active', text: '1')
expect(page).to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).to have_css('.current', text: '1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).to have_css('.current', text: '1')
expect(page).to have_css('a[data-turbo-frame]', text: '2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).to have_css('.current', text: '1')
expect(page).to have_css('a[data-turbo-frame]', text: '2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).not_to have_css('span.page.active', text: '1')
expect(page).not_to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).not_to have_css('.current', text: '1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).not_to have_css('span.page.active', text: '1')
expect(page).not_to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).not_to have_css('.current', text: '1')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).not_to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).not_to have_css('.current', text: '1')
expect(page).not_to have_css('a[data-turbo-frame]', text: '2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

expect(page).not_to have_css('span.page', text: '2')
within("nav.pagy.nav") do
expect(page).not_to have_css('.current', text: '1')
expect(page).not_to have_css('a[data-turbo-frame]', text: '2')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[rubocop] reported by reviewdog 🐶
[Corrected] Style/StringLiterals: Prefer double-quoted strings unless you need single quotes to avoid extra backslashes for escaping.

@adrianthedev adrianthedev merged commit 9e74b75 into main May 22, 2024
18 of 20 checks passed
@adrianthedev adrianthedev deleted the chore/add-erb-lint branch May 22, 2024 12:31
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant