fix: boolean group field on actions #2767
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
app/components/avo/fields/boolean_group_field/edit_component.rb
Outdated
Show resolved
Hide resolved
app/components/avo/fields/boolean_group_field/edit_component.rb
Outdated
Show resolved
Hide resolved
app/components/avo/fields/boolean_group_field/edit_component.rb
Outdated
Show resolved
Hide resolved
app/components/avo/fields/boolean_group_field/edit_component.rb
Outdated
Show resolved
Hide resolved
|
Code Climate has analyzed commit 2916816 and detected 0 issues on this pull request. View more on Code Climate. |
gabrielgiroe1
approved these changes
May 15, 2024
| def initialize(...) | ||
| super(...) | ||
|
|
||
| # Initilize here to avoid multiple calls to @field.get_html for each option. |
adrianthedev
approved these changes
May 16, 2024
|
This PR has been merged into Please check the release guide for more information. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2569
Boolean group field was not respecting the form scope. For this reason, on actions, it's values was getting passed through params outside
fieldsscope behaving as unpermitted params.This PR also drops
recorddependency for boolean group fields. Now it can be used for example on an action from index view.Checklist: