fix: table cache #2734
Merged
fix: table cache #2734
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code Climate has analyzed commit 4e875ad and detected 0 issues on this pull request. View more on Code Climate. |
|
This PR has been merged into Please check the release guide for more information. |
|
Could please leave a message to why this refactor was done? |
Sure, full context on the fixed issue: #2732 Instance variables was defined and assigned inside We actually want the Pseudo code that explains the refactor: Before: cache_if ...
@variable = value
endAfter: @variable = cache_if ...
value
endMakes sense? |
|
Got it! Thank you! |
gabrielgiroe1
pushed a commit
that referenced
this pull request
May 8, 2024
* fiix: table cache * revert
Paul-Bob
added a commit
that referenced
this pull request
Aug 5, 2024
* Add support for alternative IDs using Hashids * Fix rubocop * Remove Hashid inclusion from ApplicationRecord * Add Hashid inclusion * Fix error for hashid * Fix lint error * Add hashid-rails on development test * Add require statement for hashid-rails gem in application.rb * Remove unnecessary require statement for 'hashid/rails' in application.rb * Update gemfile * Resolve conflict git reset * Add gemfiles * appraisal bundle * Replace direct record id expouser with safer alternative * Fix lint * Revert to record.id * Fix selector in tabs_spec * Fix selector in has_many * Fix selector * Fix selector * Fix selector * Fix value for id * wip * Fix enum_array_display_value_false_spec * possible quick fix for not showing belongs to * Fix has_many_field_spec * Fix fields_methods_for_views_spec * fix: check proper dir for internal controller override (#2712) * feature: configurable default pagination (#2717) * feature: configurable default pagination * add on template * revert countless config * feature: linkable association titles (#2591) * fix: eager load actions (#2719) * fix: actions eager loader (#2726) * fix: render background context when accessing extrernal action links (#2730) * fix: actions links POC * wip * TODO * wip * wip * correct frame id * lint * lint * fix: don't export `avo.custom.js` build (#2731) * Bumped avo to 3.6.2 * fix: cache_table_rows (#2733) * Bumped avo to 3.6.3 * fix: table cache (#2734) * fiix: table cache * revert * Bumped avo to 3.6.4 * fix: resource controls spacing issue (#2740) * fix: check if ActionText::RichText is defined (#2741) * Bumped avo to 3.7.0 * chore(deps): bump trix in the npm_and_yarn group across 1 directory (#2749) Bumps the npm_and_yarn group with 1 update in the / directory: [trix](https://github.com/basecamp/trix). Updates `trix` from 2.1.0 to 2.1.1 - [Release notes](https://github.com/basecamp/trix/releases) - [Commits](basecamp/trix@v2.1.0...v2.1.1) --- updated-dependencies: - dependency-name: trix dependency-type: direct:production dependency-group: npm_and_yarn ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * chore: require ostruct (#2750) * [js] Update all Yarn dependencies (2024-04-25) (#2720) Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com> Co-authored-by: Paul Bob <69730720+Paul-Bob@users.noreply.github.com> Co-authored-by: Adrian Marin <adrian@adrianthedev.com> * wip * feature: heading target (#2753) * Update Gemfile * Resolve conflict git reset * Update Gemfile * Removed duplication * Removed duplication * wip * wip * wip * tweaks for #2564 (#2776) * tweaks * . * lint * . * test * tweak * revert tests on special branch * wip * wip * wip * wip * wip * Update lib/avo/fields/belongs_to_field.rb * . * belongs to field tweaks * lint * bundle * fix belongs_to * force lock * bundle * try --full-index * appraisal update rubocop * rm --full-index * add record_param * fix target_resource * tweaks * wip * fix target_resource * ransack cleanup * dont include hashids for rails 8 * attach issue message * fix belongs to selects --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Paul Bob <paul.ionut.bob@gmail.com> Co-authored-by: Paul Bob <69730720+Paul-Bob@users.noreply.github.com> Co-authored-by: Adrian Marin <adrian@adrianthedev.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: depfu[bot] <23717796+depfu[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #2732
Refactor rows and header cache
Checklist: