-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: profile and cover photos #2722
Conversation
Code Climate has analyzed commit 8c32a51 and detected 0 issues on this pull request. View more on Code Climate. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking great!
I have one concern about the way to declare the cover/photo components. IMO it should not rely on existing fields, and pass the photo URL directly on the API like grid view cover.
Pros:
- Any image can be used even an external URL
- Custom path helpers can be used to get the image URL
- No need of field declaration if user don't want to have that fields.
self.cover_photo = -> do
{
# size: :sm,
source: main_app.url_for(record.cover_photo.url)
}
end
yup! makes sense! |
This PR has been marked as stale because there was no activity for the past 15 days. |
Let's look into memoization of these obejcts ( Maybe https://github.com/panorama-ed/memo_wise? Let's evaluate it |
Implements RSpec tests for Avo's event page cover and profile photos components, ensuring proper visibility under various conditions.
For more details, open the Copilot Workspace session. |
Implements RSpec tests for Avo's event page cover and profile photos components, ensuring proper visibility under various conditions. - **Adds component tests** for both `Avo::CoverPhotoComponent` and `Avo::ProfilePhotoComponent` to verify rendering logic based on the presence and visibility of photos. These tests cover scenarios where photos are present, absent, not visible in the current view, and dynamically sourced. - **Updates feature tests** in `spec/features/avo/cover_profile_photos_spec.rb` to include scenarios for an event page without cover and profile photos, with only a cover photo, with only a profile photo, and with both photos. This ensures the application behaves as expected under each condition. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/avo-hq/avo/pull/2722?shareId=76ee8294-b3dd-4b08-b5a6-3fb721ad01af).
This PR has been merged into Please check the release guide for more information. |
Description
Adds a cover and profile photo to the show view of the record.
Docs: https://docs.avohq.io/3.0/cover-and-profile-photos.html
Todo:
Checklist:
Screenshots & recording
Manual review steps
Manual reviewer: please leave a comment with output from the test if that's the case.