Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: detach action record #2690

Merged
merged 2 commits into from
Apr 18, 2024
Merged

fix: detach action record #2690

merged 2 commits into from
Apr 18, 2024

Conversation

Paul-Bob
Copy link
Contributor

Description

Fixes #2568

record variable on detach_... method was actually the parent record instead the detached record as expected and documented.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
    please leave a comment with output from the test if that's the case.

@Paul-Bob Paul-Bob added the Fix label Apr 15, 2024
@Paul-Bob Paul-Bob requested a review from adrianthedev April 15, 2024 16:04
@Paul-Bob Paul-Bob self-assigned this Apr 15, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 15, 2024 •
edited
Loading

Code Climate has analyzed commit da87282 and detected 0 issues on this pull request.

View more on Code Climate.

adrianthedev
adrianthedev approved these changes Apr 15, 2024
View reviewed changes
Copy link
Collaborator

@adrianthedev adrianthedev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Paul-Bob Paul-Bob merged commit 87e8390 into main Apr 18, 2024
19 of 20 checks passed
@Paul-Bob Paul-Bob deleted the fix/detach_action_record branch April 18, 2024 09:00
@github-actions GitHub Actions
Copy link
Contributor

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev adrianthedev approved these changes

Assignees

@Paul-Bob Paul-Bob

Labels
Authorization Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

When trying to detach has_many association it policy record becomes different model
2 participants
@Paul-Bob @adrianthedev