Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: hydrate resource with record when detect_fields on new #2659

Merged
merged 4 commits into from
Apr 4, 2024
Merged

fix: hydrate resource with record when detect_fields on new #2659

merged 4 commits into from
Apr 4, 2024

Conversation

Paul-Bob
Copy link
Contributor

@Paul-Bob Paul-Bob commented Apr 4, 2024

Description

Fixes https://discord.com/channels/740892036978442260/1201874761546735636/1225395037047619664

Ensure that record is present when detect_fields is called on new action.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works

@Paul-Bob Paul-Bob added the Fix label Apr 4, 2024
@Paul-Bob Paul-Bob requested a review from adrianthedev April 4, 2024 11:41
@Paul-Bob Paul-Bob self-assigned this Apr 4, 2024
@codeclimate CodeClimate
Copy link

codeclimate bot commented Apr 4, 2024 •
edited
Loading

Code Climate has analyzed commit 040e6c2 and detected 0 issues on this pull request.

View more on Code Climate.

@Paul-Bob Paul-Bob merged commit 9c380ac into main Apr 4, 2024
19 of 20 checks passed
@Paul-Bob Paul-Bob deleted the fix/hydrate_resource_with_record_on_new branch April 4, 2024 16:59
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 4, 2024

This PR has been merged into main. The functionality will be available in the next release.

Please check the release guide for more information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrianthedev adrianthedev Awaiting requested review from adrianthedev

Assignees

@Paul-Bob Paul-Bob

Labels
Fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Paul-Bob