-
-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature: resource controls dynamic width #2583
feature: resource controls dynamic width #2583
Conversation
Update width for table_header resource control Update padding in table_row_component
Code Climate has analyzed commit 529f4fc and detected 0 issues on this pull request. View more on Code Climate. |
Thanks, @anjoseb121, for this! I see some issues with left-side placement, and the same is true for the right side. It seems to try to take up more space than it really needs. I think this happens when the page is larger in width than the minimum size table. |
@adrianthedev thanks for the review! I've fixed it with the last commit |
Hey @anjoseb121 I pushed a few changes to account for some more scenarios. |
@adrianthedev Looks great! Thanks for that! |
This PR has been marked as stale because there was no activity for the past 15 days. |
@anjoseb121 @adrianthedev could you take a look please? ^^ |
@xeron sure, I can improve it! |
I just saw @adrianthedev opened a PR for it, thanks for that! |
Yeah. It was a pretty wuick fix |
Description
Resource controls should use the space based on the number of actions it has. Also I've updated the padding style, now it won't show empty space when there's no action.
resource_controls_component.html.erb
component.w-full
style in theresource_controls_component.html.erb
max-w-24
.px-2
from thetable_row_component.html.erb
component, the padding is handled by the resource_controls componentFixes #2404
Checklist:
Screenshots & recording
Manual review steps
config.resource_controls_placement = :left
option in the initializerManual reviewer: please leave a comment with output from the test if that's the case.