eliminates hacky overloads ! #129
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JuliaLang/julia#39305 is merged, and now we can really clean up our `abstractinterpretation.jl`. The legacy hacky overloads will be kept in `src/legacy/abstractinterpretation.jl` for the compatbility with Julia v1.6. JET benchmark will also show the impact analysis of constant prop' on union-split signatures on JET analysis.
Codecov Report
@@ Coverage Diff @@
## master #129 +/- ##
==========================================
- Coverage 82.47% 82.44% -0.03%
==========================================
Files 11 11
Lines 1164 1185 +21
==========================================
+ Hits 960 977 +17
- Misses 204 208 +4
Continue to review full report at Codecov.
|
2080095 to
561a3e4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JuliaLang/julia#39305 is merged, and now we can
really clean up our
abstractinterpretation.jl.The legacy hacky overloads will be kept in
src/legacy/abstractinterpretation.jlfor the compatbility with Julia v1.6.
JET benchmark will also show the impact analysis of constant prop' on
union-split signatures on JET analysis.