Make override explicit by doing it in the original module in an initializer #6125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dananji
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #6124
Before this change the overridden helper method was not loading correctly and Blacklight's original implementation was executing causing the return value to be a SolrDocument which led to incorrect urls in the search results. This is probably due to a change in the way zeitwerk autoloading works in Rails 7.2 and only manifests in production environment. It doesn't appear in the development environment because of a reloading workaround that targets the development environment (see #1747). This workaround also fixes the issue in production but it the change in this PR feels like a better solution for this specific problem as well as being more limited in scope.