Skip found in transcript if there are curly brackets in query #5968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On mco-staging, an Atom feed request was failing because the query was
other_identifier_sim:/GR[0-9]{8}/. I eventually determined that it was not an issue with this being turned intotranscript_tsim:other_identifier_simand that it was not an issue with the Regex formatting of the query.The behavior that I ultimately determined was the culprit was the curly braces. Any search conducted in Avalon that contains curly braces will fail, even though the search query is escaped for Solr. I do not know if this is a bug upstream in RSolr with the
solr_escapemethod or if this is an issue in Solr itself where it is not respecting the escaping like it should in this context.For now, skipping the transcript search if there are curly braces in the query seemed like the easiest approach.
Related issue: #5967