Fix links in footer #5960
Merged
Fix links in footer #5960
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjcolvar
reviewed
Jul 29, 2024
|
Weird. Worked when I tested it so I wonder what's different...anyway, I can look at it more deeply tomorrow. |
cjcolvar
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #5879, we set the footer to a negative z-index in order to get playlist paging to work. We did not catch/realize that negative z-indexes disable links, because elements are actually placed behind their containers. This PR sets the footer z-index explicitly to 0 to reenable the "Contact Us" and other links in the footer. It also sets the playlist pagination z-index to 10, so that its actions will not be covered by the footer again.