Add setting for alternative rack tempfile directory #5958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Mason Ballengee <masaball@iu.edu>
Co-authored-by: Chris Colvard <chris.colvard@gmail.com>
cjcolvar
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: #5948
The variable that needs to be set to override the default factory is part of the Rack
request.envhash. Creating a custom middleware to handle injecting the lambda seemed to be the best approach.Having the error handling in the initialize method will log any issues once during app startup. The factory logic can be called multiple times during a single upload, so this seemed like the simplest way to get the error logged without triggering, potentially multiple times, on every upload in the application. It does run the risk of not being noticed that way though so I'm not sure which approach is actually better.