Fix enabling of media object action buttons #5947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dananji
previously approved these changes
Jul 18, 2024
On page load, both initial and refreshed, in mobile browsers there was some sort of race condition that was disabling the Add to Playlist, Timeline, and Thumbnail buttons immediately after being enabled. Changing the event listener for disabling the buttons to be triggered on the player emptying instead of loading seems to fix that race condition, but uncovered a separate one when switching canvases. This second race condition behaved similarly to the first, where the enabling function would be run before the disabling function. Adding a fallback enabling function that triggers on loadstart seems to fix this second race condition. There may still be some flakiness, especially on apple devices, because events triggering properly sometimes just doesn't happen.
49045cd to
aa5df51
Compare
cjcolvar
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On page load, both initial and refreshed, in mobile browsers there was some sort of race condition that was disabling the Add to Playlist, Timeline, and Thumbnail buttons immediately after being enabled. Changing the event listener for disabling the buttons to be triggered on the player emptying instead of loading seems to fix that race condition, but uncovered a separate one when switching canvases. This second race condition behaved similarly to the first, where the enabling function would be run before the disabling function. Adding a fallback enabling function that triggers on loadstart seems to fix this second race condition. There may still be some flakiness, especially on apple devices, because events triggering properly sometimes just doesn't happen.
Related issue: #5885
Wait to merge until after 7.8