Use plain old javascript to get de-duplication of listener registration #5775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
compared network tab in dev tools on demo site and avalon-staging. On demo site, there were many calls to POST https://demo.avalonmediasystem.org/master_files/pc289j26r/still and then to GET the media https://demo.avalonmediasystem.org/media_objects/vd66w013p. On avalon-staging, I only see one of each when I create a thumbnail in both Chrome and Safari, so this looks good to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this change
setInterval(enableCreateThumbnail)would register the show and update handlers hundreds of times (depending on how long the page had been loaded) leading to the same large number of requests to fetch the poster image or post the update. This PR usesaddEventListenerwhich de-duplicates listeners when registered with a function.Related to #5743