Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display comments, tags for an empty playlist #5773

Merged
merged 2 commits into from
Apr 10, 2024
Merged

Conversation

Dananji
Copy link
Contributor

@Dananji Dananji commented Apr 5, 2024

Related issue: samvera-labs/ramp#457

The changes in this PR are associated with samvera-labs/ramp#475. To finish this work a new Ramp build with these changes should be brought into Avalon.

An empty playlist with be displayed as follows with emptyManifestMessage='This playlist currently has no playable items.';

Screenshot 2024-04-05 at 1 31 56 PM

@Dananji Dananji marked this pull request as draft April 5, 2024 17:46
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far.

@Dananji Dananji marked this pull request as ready for review April 8, 2024 13:56
@Dananji Dananji merged commit f958701 into develop Apr 10, 2024
2 checks passed
@Dananji Dananji deleted the empty-playlist-message branch April 10, 2024 13:51
cjcolvar pushed a commit that referenced this pull request Apr 26, 2024
* Display comments, tags for an empty playlist

* Ramp build with related changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants