Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add handling of transcripts file to Batch Ingest #5747

Merged
merged 3 commits into from
May 2, 2024
Merged

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Mar 25, 2024

This branch is built off prior, unmerged work to add support of uploading multiple caption files via batch manifest

PR #5704 should be reviewed and merged before this PR. has been merged.

@masaball masaball force-pushed the batch_transcripts branch 2 times, most recently from 1e8cc79 to acb9993 Compare April 5, 2024 18:12
@masaball masaball marked this pull request as ready for review April 5, 2024 18:18
@masaball masaball force-pushed the batch_transcripts branch from acb9993 to 690ab08 Compare April 15, 2024 15:04
cjcolvar
cjcolvar previously approved these changes Apr 16, 2024
Copy link
Member

@cjcolvar cjcolvar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I had one small non-blocking suggestion.

cjcolvar
cjcolvar previously approved these changes Apr 17, 2024
@cjcolvar cjcolvar dismissed their stale review April 26, 2024 20:31

The merge-base changed after approval.

@masaball masaball force-pushed the batch_transcripts branch from 13912c3 to a5dc0ec Compare April 29, 2024 14:31
@masaball masaball merged commit 7fcc81e into develop May 2, 2024
2 checks passed
@masaball masaball deleted the batch_transcripts branch May 2, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants