Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove captions from HLS manifest #5735

Merged
merged 1 commit into from
Mar 14, 2024
Merged

Remove captions from HLS manifest #5735

merged 1 commit into from
Mar 14, 2024

Conversation

masaball
Copy link
Contributor

@masaball masaball commented Mar 13, 2024 •
edited
Loading

Related Issues: #5695, #5722

Dananji
Dananji approved these changes Mar 14, 2024
View reviewed changes
Copy link
Contributor

@Dananji Dananji left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as far as I can tell 👍

Could you please add a description/link to a related issue in the PR description for context? If we ever need to refer back to this in the future, that would be helpful. Thanks!

@masaball masaball merged commit 20efa05 into develop Mar 14, 2024
2 checks passed
@masaball masaball deleted the remove_hls_captions branch March 14, 2024 15:09
@masaball masaball mentioned this pull request Aug 2, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Dananji Dananji Dananji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@masaball @Dananji