Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip out childless paths from structural metadata to ensure valid manifest #5113

Merged
merged 1 commit into from
Mar 14, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Mar 14, 2023

These changes ensure a valid IIIF manifest is returned when the stored XML structural metadata contains blank divs. This allows the SME to load instead of erroring.

This PR leaves the Error in place but it really shouldn't be raised. Do you think it should be removed?

Related to avalonmediasystem/react-structural-metadata-editor#176

Copy link
Contributor

@Dananji Dananji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@cjcolvar cjcolvar merged commit 85d6bb9 into develop Mar 14, 2023
@cjcolvar cjcolvar deleted the valid_structs branch March 14, 2023 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants