Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Override SearchService#count to ensure it uses the preferred http method… #5102

Merged
merged 1 commit into from
Mar 9, 2023
Merged

Override SearchService#count to ensure it uses the preferred http method… #5102

merged 1 commit into from
Mar 9, 2023

Conversation

cjcolvar
Copy link
Member

@cjcolvar cjcolvar commented Mar 7, 2023

…instead of assuming GET, which doesn't work for lengthy requests.

Related to issues with media_objects.json endpoint.

@cjcolvar
Override SearchService#count to ensure it uses the preferred http met…
b09cd3b 
…hod instead of assuming GET, which doesn't work for lengthy requests
masaball
masaball approved these changes Mar 9, 2023
View reviewed changes
Copy link
Contributor

@masaball masaball left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@masaball masaball merged commit e1e5bc5 into develop Mar 9, 2023
@masaball masaball deleted the kaminari_post branch March 9, 2023 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masaball masaball masaball approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cjcolvar @masaball